Skip to content

Commit

Permalink
chore: lock npm version for CI (#762)
Browse files Browse the repository at this point in the history
* chore: limit npm version to 9 in ci for compatibility with node 16

* changelog
  • Loading branch information
krpeacock authored Sep 6, 2023
1 parent ac76756 commit 78e6e56
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
with:
node-version: ${{ matrix.node }}

- run: npm install -g npm
- run: npm install -g npm@9

- run: npm install

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- run: npm install -g npm
- run: npm install -g npm@9
- run: npm install
- run: npm run lint --workspaces --if-present
2 changes: 1 addition & 1 deletion .github/workflows/mitm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
with:
node-version: ${{ matrix.node }}

- run: npm install -g npm
- run: npm install -g npm@9

- run: npm install

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prettier.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- run: npm install -g npm
- run: npm install -g npm@9
- run: npm install prettier pretty-quick
- run: npm run prettier:check

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/size-limit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
CI_JOB_NUMBER: 1
steps:
- uses: actions/checkout@v1
- run: npm install -g npm
- run: npm install -g npm@9
# - run: npm run size-limit --workspaces --if-present

# commented out until the job can be configured
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
with:
node-version: ${{ matrix.node }}

- run: npm install -g npm
- run: npm install -g npm@9

- run: npm ci

Expand Down
1 change: 1 addition & 0 deletions docs/generated/changelog.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ <h1>Agent-JS Changelog</h1>
<section>
<h2>Version x.x.x</h2>
<ul>
<li>chore: limit npm version to 9 in ci for compatibility with node 16</li>
<li>
Adds more helpful error message for when principal is undefined during actor creation
</li>
Expand Down

0 comments on commit 78e6e56

Please sign in to comment.