chore: updating dependencies for elliptic advisory (#912)

* chore: updating dependencies for elliptic advisory * feat: replaces hdkey and bip32 implementations with `@scrue/bip39` and `@scrue/bip39` * chore: cleaning up newly flagged eslint errors * increasing timeout for flakey test * Update CHANGELOG.md
dfinity · Aug 5, 2024 · 3b4df1b · 3b4df1b
1 parent ed4f2d0
commit 3b4df1b
Show file tree

Hide file tree

Showing 28 changed files with 2,890 additions and 2,955 deletions.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -8,6 +8,9 @@
 
 - ci: removing headless browser tests pending a rewrite
 - ci: changing token for creating release
+- feat: replaces hdkey and bip32 implementations with `@scure/bip39` and `@scure/bip32` due to vulnerability and lack of maintenance for `elliptic`
+- chore: bumps dev dependency versions to remove warnings
+- chore: addresses eslint errors uncovered by bumping eslint version
 
 ### Added
 

diff --git a/e2e/node/basic/identity.test.ts b/e2e/node/basic/identity.test.ts
@@ -1,6 +1,5 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
 import { Actor, SignIdentity } from '@dfinity/agent';
-import { IDL } from '@dfinity/candid';
 import { Principal } from '@dfinity/principal';
 import {
   DelegationChain,
@@ -28,7 +27,7 @@ function createSecpIdentity(seed: number): SignIdentity {
 async function createIdentityActor(
   seed: number,
   canisterId: Principal,
-  idl: IDL.InterfaceFactory,
+  idl,
 ): Promise<any> {
   const identity = createIdentity(seed);
   const agent1 = await makeAgent({ identity });
@@ -40,7 +39,7 @@ async function createIdentityActor(
 
 async function createSecp256k1IdentityActor(
   canisterId: Principal,
-  idl: IDL.InterfaceFactory,
+  idl,
   seed?: number,
 ): Promise<any> {
   let seed1: Uint8Array | undefined;
@@ -59,10 +58,9 @@ async function createSecp256k1IdentityActor(
 
 async function createEcdsaIdentityActor(
   canisterId: Principal,
-  idl: IDL.InterfaceFactory,
+  idl,
   identity?: SignIdentity,
 ): Promise<any> {
-  global.crypto;
   let effectiveIdentity: SignIdentity;
   if (identity) {
     effectiveIdentity = identity;
@@ -80,7 +78,7 @@ async function createEcdsaIdentityActor(
 
 async function installIdentityCanister(): Promise<{
   canisterId: Principal;
-  idl: IDL.InterfaceFactory;
+  idl;
 }> {
   const { canisterId, idl } = await identityCanister();
   return {

diff --git a/e2e/node/basic/mainnet.test.ts b/e2e/node/basic/mainnet.test.ts
@@ -21,7 +21,8 @@ const createWhoamiActor = async (identity: Identity) => {
   const idlFactory = () => {
     return IDL.Service({
       whoami: IDL.Func([], [IDL.Principal], ['query']),
-    });
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    }) as unknown as any;
   };
   vi.useFakeTimers();
   new Date(Date.now());
@@ -136,7 +137,7 @@ describe('call forwarding', () => {
       requestId,
       defaultStrategy(),
     );
-    certificate; // Certificate
-    reply; // ArrayBuffer
+    expect(certificate).toBeTruthy();
+    expect(reply).toBeTruthy();
   }, 15_000);
 });
diff --git a/e2e/node/basic/watermark.test.ts b/e2e/node/basic/watermark.test.ts
@@ -45,7 +45,6 @@ function indexOfQueryResponse(history: Response[]) {
 
 test('basic', async () => {
   const fetchProxy = new FetchProxy();
-  global.fetch;
 
   const actor = await createActor({
     fetch: fetchProxy.fetch.bind(fetchProxy),
@@ -60,7 +59,6 @@ test('basic', async () => {
 
 test('replay queries only', async () => {
   const fetchProxy = new FetchProxy();
-  global.fetch;
 
   const actor = await createActor({
     fetch: fetchProxy.fetch.bind(fetchProxy),
@@ -83,7 +81,6 @@ test('replay queries only', async () => {
 
 test('replay attack', async () => {
   const fetchProxy = new FetchProxy();
-  global.fetch;
 
   const actor = await createActor({
     verifyQuerySignatures: true,

diff --git a/e2e/node/canisters/counter.ts b/e2e/node/canisters/counter.ts
@@ -1,5 +1,4 @@
 import { Actor, ActorSubclass, HttpAgentOptions, Agent } from '@dfinity/agent';
-import { IDL } from '@dfinity/candid';
 import { Principal } from '@dfinity/principal';
 import { readFileSync } from 'fs';
 import path from 'path';
@@ -12,7 +11,7 @@ let cache: {
   actor: any;
 } | null = null;
 
-const idl: IDL.InterfaceFactory = ({ IDL }) => {
+const idl = ({ IDL }) => {
   return IDL.Service({
     inc: IDL.Func([], [], []),
     inc_read: IDL.Func([], [IDL.Nat], []),
@@ -58,7 +57,7 @@ export const createActor = async (options?: HttpAgentOptions, agent?: Agent) =>
     if (!options?.host?.includes('icp-api')) {
       await effectiveAgent.fetchRootKey();
     }
-  } catch (_) {
+  } catch {
     //
   }
 

diff --git a/e2e/node/package.json b/e2e/node/package.json
@@ -24,7 +24,6 @@
   },
   "devDependencies": {
     "@peculiar/webcrypto": "^1.4.0",
-    "@trust/webcrypto": "^0.9.2",
     "@tsconfig/node16": "^1.0.3",
     "@tsconfig/node17": "^1.0.1",
     "@types/base64-js": "^1.3.0",
@@ -34,16 +33,13 @@
     "@typescript-eslint/parser": "^5.30.5",
     "agent1": "npm:@dfinity/agent@^1.4.0",
     "esbuild": "^0.15.16",
-    "eslint": "^8.19.0",
-    "eslint-plugin-jsdoc": "^39.3.3",
     "isomorphic-fetch": "^3.0.0",
     "locus": "^2.0.4",
     "node-webcrypto-p11": "^2.5.0",
     "size-limit": "^8.2.6",
     "text-encoding": "^0.7.0",
     "ts-node": "^10.8.2",
     "typescript": "^5.2.2",
-    "vitest": "^0.34.6",
-    "webcrypto-core": "^1.7.5"
+    "vitest": "^0.34.6"
   }
 }
diff --git a/e2e/node/utils/agent.ts b/e2e/node/utils/agent.ts
@@ -16,7 +16,7 @@ export const makeAgent = async (options?: HttpAgentOptions) => {
   });
   try {
     await agent.fetchRootKey();
-  } catch (_) {
+  } catch {
     //
   }
   return agent;