Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Add pre commit and linting #15

Conversation

jeffmcutter
Copy link

  • Add ansible-lint and pre-commit config files.
  • Add pre-commit to requirements.txt.
  • Add ansible-lint github workflow.
  • Commit pre-commit and ansible-lint fixes excluding syntax_highlighting_demo.yml.

@svor svor self-requested a review December 20, 2023 16:38
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffmcutter thank you for the PR!
Please resolve the conflict and we are good to merge it

@svor
Copy link
Collaborator

svor commented Jan 8, 2024

@jeffmcutter I see that ansible-lint check was failed, could you please take a look

@jeffmcutter
Copy link
Author

It's intentional for the demo of ansible-lint in VS Code and pre-commit.

@svor
Copy link
Collaborator

svor commented Jan 8, 2024

It's intentional for the demo of ansible-lint in VS Code and pre-commit.
Got it, thanks!

I don't see how we can exclude syntax_highlighting_demo.yml file in ansible-lint workflow.

Maybe we can remove syntax_highlighting_demo.yml from the sample at all? I don't think it's important to have it. If we want to show how the linter works, we can open any playbook from the sample and make changes there.

Because right now the workflow isn't useful, we'll have it failed every time

@jeffmcutter WDYT?

@jeffmcutter
Copy link
Author

How about I exclude that file from ansible-lint? That way the pipeline can pass and if someone wants to demo/try the linting and pre-commit they can copy or rename the file.

@svor svor merged commit 5e6d8a2 into devspaces-samples:devspaces-3-rhel-8 Jan 9, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants