Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't increment podHealthChecked metric on internal check (do it only for unresponsive pods) #149

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Don't increment podHealthChecked metric on internal check (do it only for unresponsive pods) #149

merged 2 commits into from
Nov 5, 2024

Conversation

ghostdogpr
Copy link
Collaborator

Since we introduce a regular health check, the metric became a little bit useless. Increment it only when a pod is reported or found unresponsive.

@ghostdogpr ghostdogpr merged commit 5b460e7 into series/2.x Nov 5, 2024
5 checks passed
@ghostdogpr ghostdogpr deleted the metric branch November 5, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox213 nox213 nox213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostdogpr @nox213