Expose current pod assignments #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Oct 16, 2024
| @@ -127,7 +127,13 @@ class Sharding private ( | |||
| pod = shards.get(shardId) | |||
| } yield pod.contains(address) | |||
|
|
|||
| def getPods: UIO[Set[PodAddress]] = | |||
| val getAssignments: UIO[Map[ShardId, PodAddress]] = | |||
There was a problem hiding this comment.
Can you also add them to the companion object like getPods?
|
|
ghostdogpr
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: https://discord.com/channels/629491597070827530/1017210544295522325/1282152828911091793
Exposing the list of assignments helps with some kinds of optimizations, like when creating entities: the business logic can use the information to pick an entity id which has a local shard id. This saves round trip when
simulateRemotePods=false.This information is already visible with the storage api, although inefficient.
I've also made some frequently used ZIO values into
val.