Bump Caliban to 2.6.0 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Apr 25, 2024
build.sbt
Outdated
| "com.softwaremill.sttp.tapir" %% "tapir-json-zio" % "1.9.8" | ||
| "com.github.ghostdogpr" %% "caliban" % calibanVersion, | ||
| "com.github.ghostdogpr" %% "caliban-quick" % calibanVersion, | ||
| "com.softwaremill.sttp.tapir" %% "tapir-json-zio" % "1.9.8" |
There was a problem hiding this comment.
I think caliban-quick depends on jsoniter so we can get rid of this too?
build.sbt
Outdated
| "com.github.ghostdogpr" %% "caliban-quick" % calibanVersion, | ||
| "com.github.ghostdogpr" %% "caliban-zio-http" % calibanVersion, | ||
| "com.softwaremill.sttp.tapir" %% "tapir-json-zio" % "1.9.8" | ||
| "com.github.ghostdogpr" %% "caliban" % calibanVersion, |
There was a problem hiding this comment.
Since caliban-quick depends on caliban, we can actually remove this too and only depend on caliban-quick
There was a problem hiding this comment.
Yeah sure! I'm just usually wary to use transitive deps, but will do!
| Method.ANY / "api" / "graphql" -> apiHandler, | ||
| Method.ANY / "ws" / "graphql" -> | ||
| ZHttpAdapter.makeWebSocketService(WebSocketInterpreter(interpreter)) | ||
| Method.ANY / "api" / "graphql" -> handlers.api, |
There was a problem hiding this comment.
Looks really clean now 😄
There was a problem hiding this comment.
Yeah it's really nice. The quick adapter has been working really well for us in prod so far too, so pretty confident to make this change in Shardcake as well! :)
ghostdogpr
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.