Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): fix helm prompt #47

Closed

Conversation

abolfazl8131
Copy link
Collaborator

No description provided.

@mohammadll
Copy link
Member

mohammadll commented Nov 8, 2024

I reviewed and tested your pull request, but I’m still seeing the same issues. For example, when stateless: false is set, it still creates a Deployment instead of a StatefulSet. Also, setting persistence in values.yaml doesn’t create a PVC as expected. Please take another look at these issues.

There are also a few unclear lines in the Helm prompt. For instance, saying Creating deployment.yaml based on our pods in the template is very important is confusing, as it doesn’t consider whether stateless is set to true or false. Instead of directly saying what should be created (like Deployment, StatefulSet, Secret or whatever), make sure the templates generate the correct resources based on the settings in values.yaml.

@mohammadll mohammadll closed this Nov 8, 2024
@abolfazl8131 abolfazl8131 deleted the Abolfazl/helm_try branch November 10, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing the Helm prompt
2 participants