Change precedence of droplet name config values #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t name from config.vm.hostname to provider.name as this is more natural (expected) behavior.
|
@seth-reeser this PR is obviously not useful since the dependent PR (#247) was closed. I also feel that giving the hostname precedence makes more sense now (since it can be defined within each |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR actually requires that PR #247 gets merged in as well, but if it does, this PR will fix issue #234. It seems that
config.vm.hostnameoverridesprovider.name, and I don't believe this is the intended functionality. By allowing users to overrideconfig.vm.hostnamewith the optionalprovider.nameto set the droplet name, we would be allowing the plugin to be more configurable by the user. There are instances where theconfig.vm.hostnameandprovider.nameoptions could be different values, and this new order would allow each to still function properly.