Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide late sudo install on DO's debian-8 image #227

Merged

Conversation

hendrikb
Copy link
Contributor

Various issues (as far as I can see #203 and #109) report a missing sudo on
DigitalOceans debian8 images. We're providing a late installation on vagrant up
which should fix these issues.

Various issues (as far as I can see devopsgroup-io#203 and devopsgroup-io#109) report a missing sudo on
DigitalOceans debian8 images. We're providing a late installation on vagrant up
which should fix these issues.
@seth-reeser
Copy link
Member

Looks good, however, please modify to use the logger and locale file.

@hendrikb
Copy link
Contributor Author

Hi @seth-reeser , As far as I can tell it actually uses the internal @logger (which in most code paths goes un-locale'd) for straight console output with VAGRANT_LOG=info.

But you prefer to have the env[:ui].info gui output to be there, with a locale'd string, right?

@seth-reeser
Copy link
Member

Yes, please use env[:ui].info. Thank you!

@hendrikb
Copy link
Contributor Author

No problem. :) There you go!

seth-reeser added a commit that referenced this pull request Jan 15, 2016
Provide late sudo install on DO's debian-8 image
@seth-reeser seth-reeser merged commit d8d216e into devopsgroup-io:master Jan 15, 2016
@seth-reeser
Copy link
Member

Looks good! Even alphabetized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants