#853: avoid the NullPointerException by providing a default one

[yurii-yu]

fixes #853

implements

• avoid the NullPointerException by providing a default parent directory

[coveralls]

Pull Request Test Coverage Report for Build 12785751311

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 7 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 67.807%

---

Files with Coverage Reduction	New Missed Lines	%
com/devonfw/tools/ide/property/PathProperty.java	7	11.94%

Totals
Change from base Build 12770927937:	-0.02%
Covered Lines:	6962
Relevant Lines:	9899

---

💛 - Coveralls

[jan-vcapgemini]

@yurii-yu Thanks for your bugfix approach. I've tested your changes with a local build.
It looks like the issue is not fixed yet:

$ ide repository An unexpected error occurred!
We are sorry for the inconvenience.
Please check the error below, resolve it and try again.
If the error is not on your end (network connectivity, lack of permissions, etc.) please file a bug:
https://github.com/devonfw/IDEasy/issues/new?assignees=&labels=bug&projects=&template=bug.md&title=java.lang.NullPointerException
java.lang.NullPointerException
        at [email protected]/java.nio.file.Files.provider(Files.java:104)
        at [email protected]/java.nio.file.Files.isRegularFile(Files.java:2362)
        at com.devonfw.tools.ide.property.PathProperty.isValidPath(PathProperty.java:128)
        at com.devonfw.tools.ide.property.PathProperty.lambda$completeValue$0(PathProperty.java:119)
        at [email protected]/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:193)
        at [email protected]/java.util.Iterator.forEachRemaining(Iterator.java:133)
        at [email protected]/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939)
        at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:556)
        at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:546)
        at [email protected]/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
        at [email protected]/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
        at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
        at [email protected]/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:611)
        at com.devonfw.tools.ide.property.PathProperty.completeValue(PathProperty.java:119)
        at com.devonfw.tools.ide.property.Property.complete(Property.java:431)
        at com.devonfw.tools.ide.property.Property.apply(Property.java:354)
        at com.devonfw.tools.ide.property.Property.apply(Property.java:338)
        at com.devonfw.tools.ide.context.AbstractIdeContext.completeCommandlet(AbstractIdeContext.java:976)
        at com.devonfw.tools.ide.context.AbstractIdeContext.complete(AbstractIdeContext.java:927)
        at com.devonfw.tools.ide.commandlet.CompleteCommandlet.run(CompleteCommandlet.java:53)
        at com.devonfw.tools.ide.context.AbstractIdeContext.applyAndRun(AbstractIdeContext.java:875)
        at com.devonfw.tools.ide.context.AbstractIdeContext.run(AbstractIdeContext.java:805)
        at com.devonfw.tools.ide.cli.Ideasy.runOrThrow(Ideasy.java:89)
        at com.devonfw.tools.ide.cli.Ideasy.run(Ideasy.java:52)
        at com.devonfw.tools.ide.cli.Ideasy.main(Ideasy.java:29)
        at [email protected]/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)

If you want, I could show you how to build the native image and how a test for this issue could look like.

[jan-vcapgemini]

The issue seems to be not fixed yet. Please check.

[hohwille]

@yurii-yu thanks for your PR and this simple fix 👍
Could you also add the issue #853 to our changelog (see DoD)?
Then we can merge this PR. Thanks!

[hohwille]

@yurii-yu Thanks for your bugfix approach. I've tested your changes with a local build.
It looks like the issue is not fixed yet:

@jan-vcapgemini thanks for testing it this way. Really great because that is what I often miss in reviews due to too little time.

IMHO the method isValidPath also needs to be changed to use path argument instead of getValue().
Code seems to be a copy&pasted from validate() method but the author forgot to adjust the copied code properly.

Further we might consider getting the current working directory from IdeContext instead of hardcoding . in parent = Path.of(".").
Then we could add JUnit tests to test this feature and can verify it really works as expected without the need to build a local native image with GraalVM and run a manual test.

[yurii-yu]

Thank you @jan-vcapgemini and @hohwille
I will test it again and make sure it is fixed, moreover, I will update the changelog following the convention of DoD.