Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden message retrieval #399

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Harden message retrieval #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e671ad8
📦 switch to npm and upgrade packages
devmount Mar 21, 2023
f097f49
🔨 handle unprocessable message lists
devmount Mar 22, 2023
7c9ec30
➕ show corresponding error inidicator after processing
devmount Mar 22, 2023
293e1b6
🌐 update translations
devmount Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@ jobs:
filename=third-stats_${{ steps.version.outputs.next }}-alpha.${{ steps.timestamp.outputs.now }}.xpi
echo "Built filename ${filename}"
echo ::set-output name=name::${filename}
- name: Build app using Yarn
- name: Build app using NPM
run: |
npm install -g yarn
yarn install
yarn build
npm install
npm run build
- name: Create Thunderbird add-on (.xpi)
shell: bash
run: |
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,13 @@ If you encounter any problem, please [issue a bug report](https://github.com/dev
Here is how you can set up a local development environment:

1. [Clone](https://help.github.com/en/articles/cloning-a-repository) this project with Git
2. Install dependencies with [Yarn](https://yarnpkg.com/getting-started) by running `yarn` within the cloned directory `third-stats/`
3. Start the development server with `yarn serve`
2. Install dependencies by running `npm install` within the cloned directory `third-stats/`
3. Start the development server with `npm run serve`
4. Open development site by going to <http://localhost:8080> in your browser

Note that this tool uses [Thunderbirds WebExtension APIs](https://thunderbird-webextensions.readthedocs.io/en/latest/index.html). This means that some JavaScript objects won't be available in your browser as development environment. If you want to test your changes in Thunderbird, do the following:

5. Save all your changes and run `yarn build` to create a production build in the `dist/` directory
5. Save all your changes and run `npm run build` to create a production build in the `dist/` directory
6. Open Thunderbird, go to main menu > add-ons > gear menu > debug add-ons > This Thunderbird > Load temporary add-on
7. Now choose the manifest file inside the `dist/` directory and your modified add-on will be loaded for the current Thunderbird session. You can check the web console by clicking the button *Inspect* in the add-on tile.

Expand Down
Loading