-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: Fixup minor cire-rotate bug #2472
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2472 +/- ##
==========================================
+ Coverage 87.18% 87.19% +0.01%
==========================================
Files 238 238
Lines 45141 45185 +44
Branches 4005 4008 +3
==========================================
+ Hits 39356 39400 +44
Misses 5104 5104
Partials 681 681 ☔ View full report in Codecov by Sentry. |
ca308e8
to
8120a58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well. Gettin ga python mfe would be goods to rule out julia setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see what the bug is (since no mfe)...but will wait for it
8120a58
to
7af2372
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
WIP: MFE still pending (and therefore PR not ready for merge yet), but the fix should be OK
also improving code gen aesthetics
from
to