Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Fixup minor cire-rotate bug #2472

Merged
merged 2 commits into from
Oct 22, 2024
Merged

compiler: Fixup minor cire-rotate bug #2472

merged 2 commits into from
Oct 22, 2024

Conversation

FabioLuporini
Copy link
Contributor

@FabioLuporini FabioLuporini commented Oct 21, 2024

WIP: MFE still pending (and therefore PR not ready for merge yet), but the fix should be OK

also improving code gen aesthetics

from

         for (int x = x0_blk0, xs = 0, xr0 = (xs)%(3), xr1 = (xs + 2)%(3), xii0 = -1; x <= MIN(x_M, x0_blk0 + x0_blk0_size - 1); x += 1, xs += 1, xr0 = (xs)%(3), xr1 = (xs + 2)%(3), xii0 = 1)
          {

to

          for (int x = x0_blk0, xs = 0, xii0 = -1; x <= MIN(x_M, x0_blk0 + x0_blk0_size - 1); x += 1, xs += 1, xii0 = 1)
          {
            int xr0 = (xs)%(3);
            int xr1 = (xs + 2)%(3);

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.19%. Comparing base (154140f) to head (7af2372).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2472      +/-   ##
==========================================
+ Coverage   87.18%   87.19%   +0.01%     
==========================================
  Files         238      238              
  Lines       45141    45185      +44     
  Branches     4005     4008       +3     
==========================================
+ Hits        39356    39400      +44     
  Misses       5104     5104              
  Partials      681      681              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FabioLuporini FabioLuporini force-pushed the fixup-cire-rotate branch 2 times, most recently from ca308e8 to 8120a58 Compare October 21, 2024 09:41
Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. Gettin ga python mfe would be goods to rule out julia setup

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see what the bug is (since no mfe)...but will wait for it

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mloubout mloubout merged commit afae8af into master Oct 22, 2024
31 checks passed
@mloubout mloubout deleted the fixup-cire-rotate branch October 22, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants