Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: RxJS (original, plain) #1883

Merged
merged 3 commits into from
Oct 26, 2023
Merged

new icon: RxJS (original, plain) #1883

merged 3 commits into from
Oct 26, 2023

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Oct 5, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1830

Link to prove your SVG is correct and up-to-date.

I tried finding an icon with a wordmark but there's nothing official.
I used the #df1c85 color from the original RxJS icon for the plain icon.

Main Website: https://rxjs.dev/
Github: https://github.com/ReactiveX/rxjs

Snailedlt
Snailedlt approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for the contribution! 🙇

@Snailedlt Snailedlt requested review from a team, ConX, lunatic-fox and Panquesito7 and removed request for a team October 21, 2023 14:04
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 21, 2023
lunatic-fox
lunatic-fox approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! 👍🏼
Thank you for this contribution! 🚀

@lunatic-fox
Copy link
Contributor

image

@Snailedlt Snailedlt merged commit 5d2ea2e into devicons:develop Oct 26, 2023
5 checks passed
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@canaleal @Snailedlt
new icon: RxJS (original, plain) (devicons#1883)
717ea78 
* Added rxjs icon

* Added new lines and unified paths for plain svg

---------

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

@ConX ConX Awaiting requested review from ConX

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canaleal @lunatic-fox @Snailedlt