Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: chosen: Allow 32-bit memory ranges for memory range properties #128

Merged

Conversation

refractionware
Copy link

These properties were moved from 64-bit-specific schemas, but were never updated to allow non-64-bit memory ranges. Since there is nothing 64-bit-specific about them, update their definitions to allow 32-bit memory ranges.

These properties were moved from 64-bit-specific schemas, but were
never updated to allow non-64-bit memory ranges. Since there is nothing
64-bit-specific about them, update their definitions to allow 32-bit
memory ranges.

Signed-off-by: Artur Weber <[email protected]>
@robherring
Copy link
Member

The intent on all of these properties is they are fixed 64-bit and not dependent on #address-cells/#size-cells. It simplifies parsing/writing the properties which is done at runtime.

@refractionware
Copy link
Author

refractionware commented Feb 22, 2024

The intent on all of these properties is they are fixed 64-bit and not dependent on #address-cells/#size-cells.

Does this mean that this part of their description is incorrect?

      While this property does not represent a real hardware, the address
      and the size are expressed in #address-cells and #size-cells,
      respectively, of the root node.

I'd assume from that description that these properties should inherit the same cell size as reg properties (in which case, my PR is likely still wrong - these would need to adapt to address-cells/size-cells sizing... I suppose I can see the complexity now :) )

@robherring
Copy link
Member

I was confused... Your change is correct.

@robherring robherring merged commit 9975007 into devicetree-org:main Feb 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants