Add support for Audio Toolbox output (MacOS) #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has been mostly stable. I did ran into some issues at one point where during a track switch the |
devgianlu
requested changes
Dec 11, 2024
|
|
||
| // We need the C.AudioContext to give the callback safe access to the output context | ||
| log.Tracef("Allocating audio context") | ||
| ctx := (*C.AudioContext)(C.malloc(C.size_t(unsafe.Sizeof(C.AudioContext{})))) |
There was a problem hiding this comment.
This can be extract to a C function like the free one.
| ctx := (*C.AudioContext)(C.malloc(C.size_t(unsafe.Sizeof(C.AudioContext{})))) | ||
| if ctx == nil { | ||
| out.err <- errors.New("failed to allocate AudioContext") | ||
| return nil, errors.New("failed to allocate AudioContext") |
There was a problem hiding this comment.
Do not create the error twice, use a local variable.
| paused bool | ||
| volume float32 | ||
| err chan error | ||
| stopChan chan struct{} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from #59
Notable changes:
newOutput, make it a separatetoolboxOutputwhich can be activated by setting the backend toaudio-toolbox.go:buildconstraint printing a generic 'unsupported' messageNOTE: we could enhance the stubs so that the output knows which outputs are supported and then automatically choose a platform-specific output like
audio-toolbox.NOTE: depending on how the float32 reader is implemented, maybe having a FIFO buffer in the output could be useful? Ideally these kinds of callbacks have instant access to data without blockage (and fill remaining samples with silence if there's no data in the buffer).
Removing the local buffer in the output and having the CB read directly does not seem to cause any issues so far...
The PR is pronbably ready for review as-is, but there might be some minor issues like making sure that
out.errgets set where necessary, more comments and testing to see how it handles error cases.