Fix parent version on test devfile #216
Conversation
Signed-off-by: thepetk <[email protected]>
No I don't think so, I didn't notice this change. I think the PR I'm mentioning needs to be rebased instead. |
Signed-off-by: thepetk <[email protected]>
@Jdubrick although I think might worth pin the cc: @michael-valdron |
|
2.2.1 sounds good to me. I think we should open an issue for overhauling the tests so we can properly test 2.2.2 schemas, wdyt? @thepetk |
Yeah I didn't open something cause @michael-valdron has the intention to bring it up as a discussion topic. If needed I'll create one afterwards :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* update schema version to 2.2.2 for nodejs test child devfiles (#213) Signed-off-by: Michael Valdron <[email protected]> * add ubuntu server bypass error case for invalid registry urls (#217) Signed-off-by: Michael Valdron <[email protected]> * Fix parent version on test devfile (#216) * Fix parent version on test devfile Signed-off-by: thepetk <[email protected]> * Update parent version Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]> * bump k8s api (#212) Signed-off-by: Kartikey-star <[email protected]> * update references to Go 1.21 in docs (#218) Signed-off-by: Michael Valdron <[email protected]> * Add support for 2.3.0 schema version (#219) * updateApi.sh script includes newer schema versions Signed-off-by: Michael Valdron <[email protected]> * devfile 2.3.0 support Signed-off-by: Michael Valdron <[email protected]> * revert schema versions for testing older features Signed-off-by: Michael Valdron <[email protected]> --------- Signed-off-by: Michael Valdron <[email protected]> * Bump github.com/docker/docker (#221) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.1+incompatible to 25.0.6+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v25.0.1...v25.0.6) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update readme for 2.3.0 schema (#222) Signed-off-by: Jordan Dubrick <[email protected]> --------- Signed-off-by: Michael Valdron <[email protected]> Signed-off-by: thepetk <[email protected]> Signed-off-by: Kartikey-star <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Jordan Dubrick <[email protected]> Co-authored-by: Michael Valdron <[email protected]> Co-authored-by: Theofanis Petkos <[email protected]> Co-authored-by: Kartikey Mamgain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
What does this PR do?:
The
Test_Parent_RegistryURL.yamlconsumes the latest parent version ofnodejs. As a result any breaking changes will impact the library's tests. This PR simply fixes the version to2.2.1(current latest) so the test related to this file remain unimpacted by any changes of the `devfile/registry)Which issue(s) this PR fixes:
N/A
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Unit/Functional tests
QE Integration test
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer: