Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2.2 #210

Merged
merged 60 commits into from
Apr 4, 2024
Merged

v2.2.2 #210

merged 60 commits into from
Apr 4, 2024

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Apr 2, 2024

What does this PR do?:

Pulls v2.2.2 into release branch

Which issue(s) this PR fixes:

fixes devfile/api#1477

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Unit/Functional tests

  • QE Integration test

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

  • Client Impact

  • Gosec scans

How to test changes / Special notes to the reviewer:

maysunfaisal and others added 30 commits September 5, 2023 13:46
Signed-off-by: Maysun J Faisal <[email protected]>
The parser should act generically, and be able to parse
any file it is provided, regardless of name and file extension.

Signed-off-by: Armel Soro <[email protected]>
It actually is able to write to the path in the
Devfile object context, not just a `devfile.yaml` file

Signed-off-by: Armel Soro <[email protected]>
Signed-off-by: Armel Soro <[email protected]>
…ension)

This merges pull request #186 from rm3l/1265-support-.yml-extension

Signed-off-by: Armel Soro <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Maysun J Faisal <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Maysun J Faisal <[email protected]>
Implement Interface definition for DownloadInMemory
Add ability to use mock without passing in arguments
Update mock to test devfile with private parent
Jdubrick and others added 18 commits January 8, 2024 18:33
* add multiple name conventions for devfile check

Signed-off-by: Jordan Dubrick <[email protected]>

* change order of sorting

Signed-off-by: Jordan Dubrick <[email protected]>

---------

Signed-off-by: Jordan Dubrick <[email protected]>
* Implement SECURITY-Insights.md

Signed-off-by: thepetk <[email protected]>

* Rename security insights with .yml extension

Signed-off-by: thepetk <[email protected]>

---------

Signed-off-by: thepetk <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.4.2 to 5.11.0.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](go-git/go-git@v5.4.2...v5.11.0)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…compatible (#204)

* Bump github.com/docker/docker

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.11+incompatible to 20.10.27+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v20.10.11...v20.10.27)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* bump registry library revision

Signed-off-by: Michael Valdron <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Valdron <[email protected]>
* Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7

Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.3 to 1.3.7.
- [Release notes](https://github.com/cloudflare/circl/releases)
- [Commits](cloudflare/circl@v1.3.3...v1.3.7)

---
updated-dependencies:
- dependency-name: github.com/cloudflare/circl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* revert registry-library downgrade

Signed-off-by: Michael Valdron <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Valdron <[email protected]>
* add support for 2.2.1 and 2.2.2 schema versions

Signed-off-by: Jordan Dubrick <[email protected]>

* update error output msg

Signed-off-by: Jordan Dubrick <[email protected]>

---------

Signed-off-by: Jordan Dubrick <[email protected]>
* update tests to incorporate v2.2.2 var warning changes

Signed-off-by: Jordan Dubrick <[email protected]>

* prepare for 2.2.2 release

Signed-off-by: Jordan Dubrick <[email protected]>

* update readme for 2.2.2

Signed-off-by: Jordan Dubrick <[email protected]>

* update go mod

Signed-off-by: Jordan Dubrick <[email protected]>

* update registry library dep to latest commit

Signed-off-by: Jordan Dubrick <[email protected]>

---------

Signed-off-by: Jordan Dubrick <[email protected]>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release changes for v2.2.2 looks good to merge into the v2.2.x release branch.

DCO check is failing because one of the recent merges into the main branch failed and looks to be a glitch, can see that the failing commit is signed off: 1d563eb

Build is failing due to SARIF step throwing a 403 error, this could be flaky and should re-run. If failure continues, we'll need to open a bug report as it could need a token rotation.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Release changes looks good to me.

Build is failing due to SARIF step throwing a 403 error, this could be flaky and should re-run. If failure continues, we'll need to open a bug report as it could need a token rotation.

Fixed by 0903393 to override read only permissions for gosec upload.

Copy link

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 4, 2024
@Jdubrick Jdubrick merged commit c4383df into v2.2.x Apr 4, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants