Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to use NodeJS 16 #179

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Update github actions to use NodeJS 16 #179

merged 2 commits into from
Aug 30, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Aug 28, 2023

What does this PR do?:

This PR updates all deprecated github actions using NodeJS 12 in order to use NodeJS 16. The list of actions updated are:

  • actions/checkout@v2 > actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
  • actions/setup-go@v2 > actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
  • codecov/[email protected] > codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4

Which issue(s) this PR fixes:

Fixes devfile/api#1225

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (99a3776) 60.84% compared to head (d196352) 60.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   60.84%   60.84%           
=======================================
  Files          41       41           
  Lines        5006     5006           
=======================================
  Hits         3046     3046           
  Misses       1767     1767           
  Partials      193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 799cc72 into devfile:main Aug 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deprecated Node.js 12 actions in the Library repo
2 participants