Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pre-commit hooks and GHA #116

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Jan 1, 2025

What I am changing

  • updated pre-commit hooks versions
  • updated GHA versions
  • updated uv to 0.5.x
  • removed black from dev deps, because it is not used
  • reduced permissions in GH workflows (the other two already had them set)

How you can test it

  • Setup the project via uv 0.5.13

@@ -9,7 +9,6 @@ dependencies = []
[tool.uv]
dev-dependencies = [
"arro3-core>=0.4.2",
"black>=24.10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used in the docs to format code docstrings https://mkdocstrings.github.io/python/usage/#options-summary. It looks like the most recent version of mkdocstrings added the option for that to be done using ruff as well as black, so we can remove black as long as we ensure we're using the latest mkdocstrings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, will double check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylebarron done. I lower bound mkdocstrings and added ruff as dev dependency instead. now both the docs and the source code are using ruff as formatter

Copy link
Member

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kylebarron kylebarron merged commit 6ea96bd into developmentseed:main Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants