Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python #30

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Python #30

merged 4 commits into from
Oct 8, 2024

Conversation

gadomski
Copy link
Collaborator

@gadomski gadomski commented Oct 8, 2024

What I am changing

  • Adds Python bindings via a cql2 package. A pycql2 already exists, so there's a risk of namespace battle, but I think it's ok to grab cql2. If we didn't want to grab the "generic" name, we could choose cql2rs instead.

How I did it

  • Moved fixtures/ to the top-level
  • Used the default maturin generate-ci template with a couple tweaks and a test job added

How you can test it

maturin develop --uv -m python/Cargo.toml && pytest python

Related Issues

@gadomski gadomski requested review from bitner and kylebarron October 8, 2024 13:30
@gadomski gadomski self-assigned this Oct 8, 2024
kylebarron
kylebarron reviewed Oct 8, 2024
View reviewed changes
python/requirements-dev.txt Outdated Show resolved Hide resolved
python/cql2.pyi Show resolved Hide resolved
python/src/lib.rs Show resolved Hide resolved
python/src/lib.rs Outdated Show resolved Hide resolved
python/cql2.pyi Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@gadomski gadomski mentioned this pull request Oct 8, 2024
Closed
kylebarron
kylebarron approved these changes Oct 8, 2024
View reviewed changes
.github/workflows/python.yml Outdated Show resolved Hide resolved
@gadomski gadomski force-pushed the issues/10-python branch 4 times, most recently from db65bf1 to 27d7a2d Compare October 8, 2024 23:43
@gadomski gadomski merged commit f8583d2 into main Oct 8, 2024
18 checks passed
@gadomski gadomski deleted the issues/10-python branch October 8, 2024 23:50
@gadomski gadomski mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

@bitner bitner bitner approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose to Python
3 participants
@gadomski @bitner @kylebarron