Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow implicit Z geometries #25

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Allow implicit Z geometries #25

merged 1 commit into from
Oct 7, 2024

Conversation

gadomski
Copy link
Collaborator

@gadomski gadomski commented Oct 5, 2024

What I am changing

  • Add some backflips to allow three-dimensional WKT geometries that don't say Z, per the CQL2 standard

How I did it

  • I chose to use tags to detect when WKT has 3D coordinates
  • This forced me to expose more tokens from parsing, but I think that should be ok?

Related Issues

@gadomski gadomski requested a review from bitner October 5, 2024 15:39
@gadomski gadomski self-assigned this Oct 5, 2024
@gadomski gadomski force-pushed the issues/18-implicit-z branch from 3976c10 to fb11c73 Compare October 7, 2024 18:09
@gadomski gadomski marked this pull request as ready for review October 7, 2024 18:09
bitner
bitner approved these changes Oct 7, 2024
View reviewed changes
src/cql2.pest Show resolved Hide resolved
@gadomski gadomski merged commit 2caec3e into main Oct 7, 2024
1 check passed
@gadomski gadomski deleted the issues/18-implicit-z branch October 7, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitner bitner bitner approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle 3D points without the Z
2 participants
@gadomski @bitner