Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type chainable methods generically #306

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Type chainable methods generically #306

merged 1 commit into from
Sep 18, 2024

Conversation

jwmerrill
Copy link
Member

@jwmerrill jwmerrill commented Sep 18, 2024 •
edited
Loading

Follow on to #305 which gave more specific types to some chainable methods like .blur().

This way reduces a bit of redundancy.

@jwmerrill jwmerrill requested a review from eluberoff September 18, 2024 15:41
eluberoff
eluberoff approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@eluberoff eluberoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this is a lot better.

@jwmerrill jwmerrill merged commit a639ea7 into main Sep 18, 2024
5 checks passed
@eluberoff eluberoff deleted the generic-interface branch September 18, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eluberoff eluberoff eluberoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwmerrill @eluberoff