-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make static math focusable #303
Conversation
412c028
to
c290aa4
Compare
For StaticMath, this defaults to "false" For MathField, this defaults to "true" This also adds a "focus" method to StaticMath, which automatically selects the contents
c290aa4
to
7628c5a
Compare
For clarification of the backwards-incompatibility: An existing |
I'll add some documentation for the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Only issue is the slight backwards-compatability issue, but that isn't really a problem. A permanent textarea is much easier to reason about than one that gets removed and added.
Note: as Jared noticed, this isn't backwards compatible if people are using substituteTextareas for StaticMath and don't pay attention to the tabbable property.