Dont reset cursor on window blur #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jared-hughes
requested review from
a team and
mikehaverstock
and removed request for
a team
|
Do you have a knox PR up to test this out? I'd like to play with this some. |
|
Ok so this makes sense to me that we can detect that we blurred the window and therefore don't reset the cursor position. Where do we put focus back in the mathquill when the window regains focus? I was seeing the mathquill regain focus with the cursor in the same position. That part doesn't make sense to me. It's great. I just don't understand the magic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alt-tab to a different window or Ctrl+Tab to a different tab, then switch back. Current behavior with
resetCursorOnBlur: true(which Desmos has) is to move the cursor to the end of the math field. Now, leave the cursor where it is.In Desmos:
resetCursorOnBluris used to ensure there's not a different cursor state for each mq field in the expressions list. When the user selects a new field (or clicks away from all fields), the cursor on the old one resets to the end of the field.Switching to a different tab/window doesn't change which field is selected, so it's okay to leave the cursor where it is.
I don't think this PR can be tested with mathquill's testing framework. focusBlur.test.js handles regular blurs but not window blurs.