Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix \binom and \choose #275

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Fix \binom and \choose #275

merged 4 commits into from
Feb 29, 2024

Conversation

jared-hughes
Copy link

@jared-hughes jared-hughes commented Feb 29, 2024

Mathquill supports:

  • Binomial coefficient \binom{}{} analogous to Fraction \frac{}{}
  • \choose almost analogous to typing / to create a fraction, but more analogous to \over (which also works in Mathquill)

This PR makes three changes:

  • Fixes bug where typing "choose" gave a TypeError (prototype was called without .call)
  • Allows Up and Down keys to navigate a binomial.
  • Adds better aria support.

For all three changes, the tests are copy-pasted from the fraction tests with minor changes.

@jared-hughes jared-hughes requested review from a team and RonAvitzur and removed request for a team February 29, 2024 19:16
@jared-hughes jared-hughes merged commit 43f0c60 into main Feb 29, 2024
4 checks passed
@jared-hughes jared-hughes deleted the fix-binom branch March 4, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants