-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for undo burst functionality (#36) #37
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e6f4c63
add logic to requestBurst action creator
colebillys19 41c2b18
finish up adding undo burst functionality
colebillys19 7e27197
bug fix: add canUndo to Burst local state
colebillys19 d01f4b9
removed comments
colebillys19 c6c28e2
fix undo burst bug
colebillys19 82f0e6e
add didUpdate to Burst component to check for new frames
colebillys19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,3 +60,8 @@ | |
background: #484848; | ||
border-color: #e79600; | ||
} | ||
|
||
.capturing { | ||
opacity: 0.5; | ||
pointer-events: none; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,26 @@ | ||
import { connect } from 'react-redux'; | ||
import Burst from '../components/Burst'; | ||
import { requestBurst } from '../actions'; | ||
import { requestBurst, undoBurst } from '../actions'; | ||
import panes from '../constants/pane-types'; | ||
|
||
const mapStateToProps = (state, ownProps) => { | ||
const { settings, ui } = state; | ||
const { settings, ui, images } = state; | ||
const { width, height, oversample } = settings.image; | ||
const { frames, frameIDs } = images; | ||
|
||
return { | ||
expanded: ui.expandedPane === panes.BURST, | ||
width, | ||
height, | ||
oversample | ||
oversample, | ||
frames, | ||
frameIDs | ||
}; | ||
}; | ||
|
||
const BurstContainer = connect( | ||
mapStateToProps, | ||
{ requestBurst } | ||
{ requestBurst, undoBurst } | ||
)(Burst); | ||
|
||
export default BurstContainer; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,3 +39,13 @@ export const setSliderByIndex = (idx, val) => { | |
const identifier = match[1]; | ||
calculator.setExpression({ id, latex: `${identifier}=${val}` }); | ||
}; | ||
|
||
// gets current state of calculator instance | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comments may not be necessary for these functions, they are perfectly described by their name There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
export const getCalcState = () => { | ||
return calculator.getState(); | ||
}; | ||
|
||
// accepts some calculator state and updates calculator instance | ||
export const setCalcState = state => { | ||
return calculator.setState(state); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With some of your nicely named function names, some of these comments may not be necessary :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done