Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws error on burst image capture when user inputs bad expression index #18

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

japamat0
Copy link
Contributor

Bug fix for (issue #16)
I added an additional check to ensure that the user selects an index with a valid expression, otherwise will throw the notASlider() error.

@mmmaaatttttt
Copy link
Contributor

@japamat - this looks good to me. FYI @ctlusto, once #17 is merged in it will be easier for @japamat to write a failing test to catch the bug that this PR fixes.

phillipson808 pushed a commit to phillipson808/gifsmos that referenced this pull request Jun 26, 2019
Mute preview tool when there are no frames in state
@ctlusto ctlusto merged commit 3f09a91 into desmosinc:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants