USE_MALLOCNG and USE_RNNOISE configuration variables #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not require mallocng, allow one to use system allocator by glibc.
RNNoise comes with an ML model trained using closed data. That's unacceptable in most Linux distributions due to legal issues. See discussion on Debian bug tracker: https://bugs.debian.org/980839#17
|
The build will just fail without rnnoise... |
|
IMHO it is better not to have option to build without mallocng, to indicate that other allocators are unsupported and whoever patches it is on his own |
|
I've just opened a PR with simiral features #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.