Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 Node 2 Upgrade #375

Open
wants to merge 14 commits into
base: maybe-the-real-node-is-the-friends-we-made-along-the-way
Choose a base branch
from
Open

2 Node 2 Upgrade #375

wants to merge 14 commits into from

Commits on May 23, 2023

  1. Bump more things 🤛

    @skalnik
    skalnik committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e017462 View commit details
    Browse the repository at this point in the history

  2. Patch curly to work with newer Node 🏴‍☠️ 

    Primarily `process.EventEmitter.prototype` doesn't work and we need to
`require('EventEmitter')` instead. So this line has been adjusted:
https://github.com/mafintosh/curly/blob/568c6359906dd26d58f69c4dde8c327d0b56f4ac/index.js#L51
    @skalnik
    skalnik committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1a6b784 View commit details
    Browse the repository at this point in the history

  3. Fix dice shit 🎲

    @skalnik
    skalnik committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5038af8 View commit details
    Browse the repository at this point in the history

  4. Fix louds test 🧪

    @skalnik
    skalnik committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7830f7c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Extract out waitForReply 🧯

    @skalnik
    skalnik committed May 24, 2023
    Configuration menu
    Copy the full SHA
    156f222 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Better test fixing with co 🖥️ 

    Pulled from hubot-test-helper examples
    @skalnik
    skalnik committed May 25, 2023
    Configuration menu
    Copy the full SHA
    2e0a927 View commit details
    Browse the repository at this point in the history

  2. Fix most other tests 🛠️ 

    The voting timeout test still fails 😕
    @skalnik
    skalnik committed May 25, 2023
    Configuration menu
    Copy the full SHA
    07f9b1d View commit details
    Browse the repository at this point in the history

  3. Try bumping sinon 🤷

    @skalnik
    skalnik committed May 25, 2023
    Configuration menu
    Copy the full SHA
    615a3f8 View commit details
    Browse the repository at this point in the history

  4. Get last test passing ✅

    @skalnik
    skalnik committed May 25, 2023
    Configuration menu
    Copy the full SHA
    65e7802 View commit details
    Browse the repository at this point in the history

  5. Remove an extra log line 😶

    @skalnik
    skalnik committed May 25, 2023
    Configuration menu
    Copy the full SHA
    1bf1781 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Lets vendor our curly version better 👰

    @skalnik
    skalnik committed May 26, 2023
    Configuration menu
    Copy the full SHA
    da48f04 View commit details
    Browse the repository at this point in the history

  2. Bump requests to make it happy 😄

    @skalnik
    skalnik committed May 26, 2023
    Configuration menu
    Copy the full SHA
    eb1c348 View commit details
    Browse the repository at this point in the history

  3. Small test fixes for vagrant 👹

    @skalnik
    skalnik committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3b0574f View commit details
    Browse the repository at this point in the history

Commits on May 28, 2023

  1. package-lock.json is recommended to be checked in ✅ 

    Additionally, this lock seems to function in vagrant so all is well I
guess
    @skalnik
    skalnik committed May 28, 2023
    Configuration menu
    Copy the full SHA
    99f4e92 View commit details
    Browse the repository at this point in the history