Move Fixes from Other Module #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From previous pr:
Per Google and Github, I was able to find two pieces of documentation that were important:
The first document highlights some of the attributes that the Google Cloud conneciton is relying on. I added those attributes and mapped them the way the other attributes were mapped.
The second document highlights that
assertion.actoris no longer in the GitHub OIDC token and has been replaced byassertion.actor_id. I believe this is the core of the issue, but I wanted to try and make sure to resolve everything while I was here.This should be non-breaking.(tagging this as a breaking change since it appears the existing version is, in fact, broken)