Merge pull request #1287 from dermotduffy/fix-disconnection-embla

Fix issue causing carousel to not correctly scroll
dermotduffy · Oct 7, 2023 · 04aef8a · 04aef8a
2 parents b0a8ad3 + cf8935d
commit 04aef8a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -27,7 +27,7 @@
     "custom-card-helpers": "^1.9.0",
     "date-fns": "^2.29.2",
     "date-fns-tz": "^1.3.7",
-    "embla-carousel": "8.0.0-rc12",
+    "embla-carousel": "8.0.0-rc14",
     "embla-carousel-wheel-gestures": "8.0.0-rc04",
     "home-assistant-js-websocket": "^8.0.0",
     "keycharm": "^0.4.0",

diff --git a/src/components/carousel.ts b/src/components/carousel.ts
@@ -60,6 +60,7 @@ export class FrigateCardCarousel extends LitElement {
     // plugins (which may have registered event handlers) to also be destroyed.
     // The carousel will automatically reconstruct if the component is re-rendered.
     this._carousel?.destroy();
+    this._carousel = null;
     super.disconnectedCallback();
   }
 

diff --git a/yarn.lock b/yarn.lock
@@ -2630,10 +2630,10 @@ __metadata:
   languageName: node
   linkType: hard
 
-"embla-carousel@npm:8.0.0-rc12":
-  version: 8.0.0-rc12
-  resolution: "embla-carousel@npm:8.0.0-rc12"
-  checksum: 553f33f562458d7fd0cd4eff1db96ac3a02352b620705d892eb3d9a297924fa12fedaf5a5aa03418dd41905ce80997a99f8aeca955d024d5a49a56f5c7fbe63b
+"embla-carousel@npm:8.0.0-rc14":
+  version: 8.0.0-rc14
+  resolution: "embla-carousel@npm:8.0.0-rc14"
+  checksum: 48f6b7420fbb5c6800e84fb15f37fbd9b2b951b36a3f30ff66ee6121d7e722bf6bc28bd986a83136651f216940ca8e472d569774e74bf2ed01e4f8e349f74289
   languageName: node
   linkType: hard
 
@@ -3346,7 +3346,7 @@ __metadata:
     custom-card-helpers: ^1.9.0
     date-fns: ^2.29.2
     date-fns-tz: ^1.3.7
-    embla-carousel: 8.0.0-rc12
+    embla-carousel: 8.0.0-rc14
     embla-carousel-wheel-gestures: 8.0.0-rc04
     eslint: ^8.23.0
     eslint-config-airbnb-base: ^15.0.0