Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GtkStack on details and on preferences #27

Open
wants to merge 3 commits into
base: wip/gtk-3.14
Choose a base branch
from
Open

Use GtkStack on details and on preferences #27

wants to merge 3 commits into from

Conversation

cjfloss
Copy link

@cjfloss cjfloss commented Oct 31, 2015

No description provided.

@derekstavis
Copy link
Owner

Nice!! Gonna test it right now!!

@derekstavis
Copy link
Owner

As you may have noticed, a big difference from upstream to this branch on the settings dialog is the usage of a left-sided GtkNotebook. This was designed thinking about horizontal space usage, as too much option tabs used too much of horizontal estate. This PR moves the settings back into a horizontal packing, which uses more space.

Apart from this issue, is a common standard in core applications to use GtkNotebook for settings:

screenshot from 2015-10-31 16-55-25screenshot from 2015-10-31 16-54-54

For the torrent properties dialog I'd prefer trying stacking the buttons into GtkHeaderBar, which is the recommended design pattern by GNOME HIG. Anyway I don't really mind about this matter in it's current state, as some programs still uses GtkNotebook for "Properties" window, like Nautilus:

screenshot from 2015-10-31 19-07-17

Thanks for the contribution! If you want to continue making Transmission better, give a look at the open issues we have! Thanks again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants