Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix Pages build, update workflow to trigger build-only on branches #626

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

ericyhwang
Copy link
Contributor

@ericyhwang ericyhwang commented Jan 17, 2024

  • We need to run bundle install inside the docs/ directory
    • I've also enabled gem caching in the setup-ruby action, which should help speed up install times
  • To help ensure docs changes are valid, allow the workflow to run on all branch pushes, instead of just the default branch
    • Add conditionals so that only default branch pushes will run the upload and deploy steps
  • Add DOCS_DIR variable for the docs directory, so we don't have to repeat it throughout the workflow

ericyhwang and others added 2 commits January 17, 2024 14:01
… without deploy

- We need to run `bundle install` inside the `docs/` directory
- To help ensure docs changes are valid, allow the workflow to run on all branch pushes, instead of just the default branch.
- Add conditionals so only default branch pushes will run the upload and deploy steps.
@ericyhwang ericyhwang changed the title [docs] Fix Pages build, update workflow to trigger on branches though without deploy [docs] Fix Pages build, update workflow to trigger build-only on branches Jan 17, 2024
@ericyhwang ericyhwang requested a review from craigbeck January 17, 2024 22:20
@ericyhwang ericyhwang merged commit 8eedad2 into master Jan 17, 2024
5 checks passed
@ericyhwang ericyhwang deleted the fix-pages-1 branch January 17, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants