Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vargs check as arg order switched to match client Page #623

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

craigbeck
Copy link
Contributor

Unifying the Page.render and PageForServer.render args resulted in changing arg order so status is last optional arg.

This removes the now incorrect var ags handling for PageForServer.render

@craigbeck craigbeck requested a review from ericyhwang November 30, 2023 23:34
Copy link
Contributor

@ericyhwang ericyhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look into adding at least a basic server-render test, to catch future regressions that only affect the server-render path but not the client-render path.

@craigbeck craigbeck merged commit a79ca20 into master Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants