Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate container list to allow filtering #380

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dbaudracco
Copy link

@dbaudracco dbaudracco commented Nov 22, 2024

This PR fixes the exclusion of containers not working

Background

When using a spinach file like

---
popeye:
  excludes:
    linters:
      deployments:
        instances:
          - codes:
              - 106
            containers:
              - "rx:.*init.*"

I noticed that the relevant containers were not excluded:

· namespace/varnish.................................................................................😱
🐳 init-varnish
😱 [POP-106] No resources requests/limits defined.

After some debugging it appears that this is because the container list is not populated for the appropriate resources: this PR addresses the issue

· namespace/varnish.................................................................................✅

Todo

  • proper testing of the resource parsing

@dbaudracco
Copy link
Author

If I'm not wrong this supersedes #267, fixes #200 and #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant