test: improve heading-matches test cases #4586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HuanWuCode
commented
Sep 25, 2024
HuanWuCode
commented
- In the beforeEach, it's fetching the empty-heading rule using axe.utils.getRule('empty-heading'). Ensure that this rule actually includes the matches function. If not, the first test (assert.isFunction(rule.matches)) will fail.
- some test case descriptions are misleading so it clarifies that
Update the doc for clarity and consistency with present tense. Also, "rules' description and help properties as well as each checks' metadata.messages property" → should be "rule's description and help properties, as well as each check's metadata.messages property" (singular possessive for "rule" and "check," and add a comma before "as well as").
|
Thanks for the pr, but I don't think the changes improve the tests as the rule is guaranteed to exist so no need to test that it does and is a function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.