Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: MapCard 레이아웃 이슈 해결 #99

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Conversation

Doeunnkimm
Copy link
Member

🤔 해결하려는 문제가 무엇인가요?

image

위 이미지처럼 텍스트 길이가 조금 길어질 경우 레이아웃 이슈 발견했습니다.

🎉 어떻게 해결했나요?

  • 전체를 flex로 하여 가운데로 조정하는 방식으로 변경
  • 상하좌우 padding으로 5px만을 주어, 최소한의 공백 적용

📚 Attachment (Option)

적용된 후 입니다 ^_^ㅠ
image

@Doeunnkimm Doeunnkimm added the bug label Jan 7, 2024
@Doeunnkimm Doeunnkimm self-assigned this Jan 7, 2024
Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
amazing3-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 6:38am

@Doeunnkimm Doeunnkimm marked this pull request as ready for review January 7, 2024 05:42
Copy link
Collaborator

@deepbig deepbig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어푸루부~~~ 수정해줘서 고마워요~!

Copy link

@minkyung-payhere minkyung-payhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어푸루부 ~ 👍


이거 글자 더 길어지면 ellipsis 처리 되어있나용?!

Copy link

github-actions bot commented Jan 7, 2024

@Doeunnkimm
Copy link
Member Author

@deepbig @minkyung00 4글자 초과시 ellipsis 처리되도록 했습니다잇

image

피드백 주신 민경센세 무한 감사,, 🙏

Copy link
Member

@newminkyung newminkyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그저 최고..✨

@Doeunnkimm Doeunnkimm merged commit 5cd3e6d into main Jan 7, 2024
4 checks passed
@Doeunnkimm Doeunnkimm deleted the hotfix/goalCard-layout branch January 7, 2024 06:49
@Doeunnkimm Doeunnkimm changed the title bug: MapCard 레이아웃 이슈 해결 bug: MapCard 레이아웃 이슈 해결 Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants