Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 홈화면 api 연동 (useGetGoals) #55

Merged
merged 7 commits into from
Dec 22, 2023
Merged

feat: 홈화면 api 연동 (useGetGoals) #55

merged 7 commits into from
Dec 22, 2023

Conversation

Doeunnkimm
Copy link
Member

🤔 해결하려는 문제가 무엇인가요?

🎉 어떻게 해결했나요?

  • useGetGoals 사용하여 데이터 패칭
  • hydration 적용

📚 Attachment (Option)

  • 코드 중간중간에 ? 및 ||가 존재하는데, 이건 추후에 loading, error 처리 완료되면 걷어내겠습니다 ^_^ㅠ

@Doeunnkimm Doeunnkimm self-assigned this Dec 21, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
amazing3-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 8:14am

@github-actions GitHub Actions
Copy link

🚀 storybook: https://654f80d3a223555108f2a6bb-opkqenfkcy.chromatic.com/

@github-actions GitHub Actions
Copy link

🚀 storybook: https://654f80d3a223555108f2a6bb-jmknvvvomw.chromatic.com/

@github-actions GitHub Actions
Copy link

🚀 storybook: https://654f80d3a223555108f2a6bb-pcbkqnwhuj.chromatic.com/

@Doeunnkimm Doeunnkimm changed the title feat: 홈화면 api 연동 (useGetGoals) feat: 홈화면 api 연동 (useGetGoals) 및 닉네임 없이 접근 시 redirecting Dec 21, 2023
@Doeunnkimm Doeunnkimm changed the title feat: 홈화면 api 연동 (useGetGoals) 및 닉네임 없이 접근 시 redirecting feat: 홈화면 api 연동 (useGetGoals) 및 닉네임 없이 접근 시 리디렉션 Dec 21, 2023
@github-actions GitHub Actions
Copy link

🚀 storybook: https://654f80d3a223555108f2a6bb-dcpwihvekq.chromatic.com/

@Doeunnkimm Doeunnkimm changed the title feat: 홈화면 api 연동 (useGetGoals) 및 닉네임 없이 접근 시 리디렉션 feat: 홈화면 api 연동 (useGetGoals) Dec 21, 2023
@github-actions GitHub Actions
Copy link

🚀 storybook: https://654f80d3a223555108f2a6bb-jfbejqztbt.chromatic.com/

deepbig
deepbig approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@deepbig deepbig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

도은 최고최고 완벽완벽~~ 👍 💯 빌드 이슈 나온는건 PrefetchHydration 관련해서 나오는 것 같은데ㅠㅡㅠ

@github-actions GitHub Actions
Copy link

🚀 storybook: https://654f80d3a223555108f2a6bb-dbtqcuakwt.chromatic.com/

@deepbig
Copy link
Collaborator

deepbig commented Dec 22, 2023 •
edited
Loading

hydration 사용이 build 시에 문제를 발생하네요;; 찾아보니 우리가 만든 hydration은 아직 추가할 기능이 좀 있는 것 같고 (사용자별 분리 등 다른 설정들이 더 필요할 것 같아요) rewrites 사용하는 것과 같이 사용 시 사이드 이펙트가 발생한다고 하니 이번 MVP에서는 해당 적용을 빼고 반영했습다ㅠㅡㅠ hydration 기능은 다음에 더 잘 준비해서 반영하죠~

앗.. 빌드가 되네;;; 그럼 일단 반영ㄱㄱ (머쓱..)

@github-actions GitHub Actions
Copy link

🚀 storybook: https://654f80d3a223555108f2a6bb-nzilfpxcjw.chromatic.com/

@deepbig deepbig merged commit 2c9c8ec into main Dec 22, 2023
6 checks passed
@deepbig deepbig deleted the feat/home-apply-api branch December 22, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepbig deepbig deepbig approved these changes

@newminkyung newminkyung Awaiting requested review from newminkyung

@hjy0951 hjy0951 Awaiting requested review from hjy0951 hjy0951 is a code owner

Assignees

@Doeunnkimm Doeunnkimm

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Doeunnkimm @deepbig