feat: 로그인 유도 BottomSheet 추가 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doeunnkimm
requested review from
newminkyung,
hjy0951 and
deepbig
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hjy0951
approved these changes
Jan 10, 2024
Comment on lines
+1
to
+7
| [data-rsbs-header] { | ||
| @apply bg-gradient6 h-full rounded-[15px]; | ||
| } | ||
|
|
||
| [data-rsbs-content] { | ||
| @apply absolute w-full top-[15px] z-10; | ||
| } |
deepbig
approved these changes
Jan 11, 2024
src/features/home/components/loginBottomSheet/LoginBottomSheet.stories.tsx
Show resolved
Hide resolved
Comment on lines
+1
to
+7
| [data-rsbs-header] { | ||
| @apply bg-gradient6 h-full rounded-[15px]; | ||
| } | ||
|
|
||
| [data-rsbs-content] { | ||
| @apply absolute w-full top-[15px] z-10; | ||
| } |
| <StarBg /> | ||
| <div className="flex flex-col gap-4xs px-[49px] items-center"> | ||
| <Image src={LogoImage} width={133} alt="logo" /> | ||
| <Typography className="text-blue-50 font-insungit font-medium">내가 직접 그리는 나의 인생 지도</Typography> |
There was a problem hiding this comment.
거의 동일한 게 Typography type에 있네~ 둘다 로그인 화면에 사용되는 부분이라 통일해도 좋을 것 같은데~ 일단 나중에 작업할 때 비슷한 거 있다고 참고만 해줘~~~~~
Suggested change
| <Typography className="text-blue-50 font-insungit font-medium">내가 직접 그리는 나의 인생 지도</Typography> | |
| <Typography type="header1">내가 직접 그리는 나의 인생 지도</Typography> |
변경 전:
변경 후:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
🎉 어떻게 해결했나요?
📚 Attachment (Option)