Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 세부 목표 페이지에 필요한 컴포넌트 추가 #100

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

Doeunnkimm
Copy link
Member

@Doeunnkimm Doeunnkimm commented Jan 7, 2024

🤔 해결하려는 문제가 무엇인가요?

🎉 어떻게 해결했나요?

  • Input 컴포넌트 수정
    • submit 아이콘이 있는 경우 고려
    • input에 value 여부에 따라 submit 아이콘 동적으로 비활성화/활성화 스타일 적용
    • overflow가 되는 경우 고려
  • AddSubGoalPrompt 컴포넌트 추가
    image

📚 Attachment (Option)

  • AddSubGoalPrompt 컴포넌트에 하드하게 color 들어간 부분이 있는데, 해당 부분은 디자인 시스템에 명시 되어 있지 않은 컬러라 하드하게 넣었습니다.

Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
amazing3-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 10:19am

Copy link

github-actions bot commented Jan 7, 2024

Copy link
Collaborator

@deepbig deepbig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

김도은 진심 잘했다... 🥇 👍 💯 👍 💯 👍 💯 👍 💯

src/components/atoms/input/Input.tsx Outdated Show resolved Hide resolved
src/components/atoms/input/Input.tsx Outdated Show resolved Hide resolved
src/components/atoms/input/Input.tsx Show resolved Hide resolved
src/components/molecules/goalDetail/GoalDetail.stories.tsx Outdated Show resolved Hide resolved
src/hooks/useInput.ts Show resolved Hide resolved
Copy link

github-actions bot commented Jan 8, 2024

Copy link
Collaborator

@hjy0951 hjy0951 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완벽 그 잡채 도은갓...
너무 고생했습니다~!~! 🫡💯

@Doeunnkimm Doeunnkimm merged commit 0226c83 into main Jan 8, 2024
4 checks passed
@Doeunnkimm Doeunnkimm deleted the feat/detail-components branch January 8, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants