feat: Jenkins CI/CD 구현 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penrose15
reviewed
Jul 11, 2024
| """ | ||
|
|
||
| sshagent (credentials: ['jenkins-ssh']) { | ||
| sh "ssh -o StrictHostKeyChecking=no ${TARGET_HOST} '${remoteCommands}'" |
There was a problem hiding this comment.
StrictHostKeyChecking= no
이 명령어 쓰면 중간자 공격에 취약하지 않나요? 이 명령어를 써도 괜찮다고 판단이 들으셔서 그렇게 하신건까요?
There was a problem hiding this comment.
그런부분까진 생각해보지 않았는데 옵션 수정해보도록 하겠습니다~
|
수고하셨습니다! 인프라 지식이 빠삭하시군요 |
penrose15
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
spring.profiles.active만 다르게 구현하였습니다.📝 참고사항