Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: laps 필드 0.5 단위 입력 가능하도록 데이터 타입 수정 #123

Merged
merged 6 commits into from
Jul 31, 2024
Merged

feat: laps 필드 0.5 단위 입력 가능하도록 데이터 타입 수정 #123

merged 6 commits into from
Jul 31, 2024

Conversation

ywonchae1
Copy link
Member

@ywonchae1 ywonchae1 commented Jul 30, 2024 •
edited
Loading

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 바퀴 수를 0.5 단위로 입력이 가능하도록 수정하였습니다.
  • 0.5 단위가 맞는지 (3.3 따위는 불가능) 검증할 수 있는 CustomValidator를 만들었습니다.

📝 참고사항

  • @penrose15 님 작업 부분인 Timeline에서도 수정 사항이 있으니 확인해 주시면 감사하겠습니다.
  • @its-sky 님 작업 부분인 Pool에서도 수정 사항이 있으니 확인해 주시면 감사하겠습니다.
  • 제가 총 거리 계산을 단순히 바퀴 수 * 레인 길이로 작성해 버렸는데, 레인 길이는 반 바퀴이므로 (int) (바퀴 수 * 2) * 레인 길이로 계산하도록 수정하였습니다.
  • 기록 생성 시 (laps 필드 값 5.5)
Screenshot 2024-07-30 at 20 48 40
  • 기록 생성 실패 시 (laps 필드 값 5.3)
Screenshot 2024-07-30 at 20 44 15

@ywonchae1 ywonchae1 self-assigned this Jul 30, 2024
@ywonchae1 ywonchae1 linked an issue Jul 30, 2024 that may be closed by this pull request
✨ 바퀴 수 실수 입력으로 변경 #116
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Test Results

39 tests   39 ✅  2s ⏱️
 9 suites   0 💤
 9 files     0 ❌

Results for commit 595e757.

♻️ This comment has been updated with latest results.

@ywonchae1 ywonchae1 requested review from its-sky and penrose15 and removed request for its-sky July 30, 2024 11:58
penrose15
penrose15 reviewed Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@penrose15 penrose15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

its-sky
its-sky approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@its-sky its-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎯

module-domain/src/main/java/com/depromeet/memory/domain/Stroke.java Show resolved Hide resolved
@ywonchae1 ywonchae1 merged commit 4d5f08a into develop Jul 31, 2024
2 checks passed
@ywonchae1 ywonchae1 deleted the feature/116-laps-to-double branch July 31, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@its-sky its-sky its-sky approved these changes

@penrose15 penrose15 penrose15 approved these changes

Assignees

@ywonchae1 ywonchae1

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ 바퀴 수 실수 입력으로 변경
3 participants
@ywonchae1 @its-sky @penrose15