feat: 공통 예외 및 성공 Response 구현 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywonchae1
reviewed
Jul 5, 2024
| @@ -4,6 +4,7 @@ build/ | |||
| !gradle/wrapper/gradle-wrapper.jar | |||
| !**/src/main/**/build/ | |||
| !**/src/test/**/build/ | |||
| **/application-secret.properties | |||
There was a problem hiding this comment.
yml 파일에 ${변수} 로 들어가는 변수를 application-secret.properties 파일 내에 적어두면 세팅이 가능합니다! 세팅 방법에는 여러개 있는데 저는 저 방법을 사용하는 걸 선호합니다
| import com.depromeet.global.dto.type.SuccessType; | ||
|
|
||
| public enum MemberSuccessType implements SuccessType { | ||
| GET_SUCCESS("MEMBER_1", "멤버 조회에 성공하였습니다"); |
There was a problem hiding this comment.
앞에 GET은 request type이 아니라 조회라는 뜻이 맞을까요!
There was a problem hiding this comment.
음 사실 저 네이밍은 별도로 합의해서 변경해도 돼요~ 내일 얘기해봅시다!
| } | ||
|
|
||
| /** | ||
| * 500 INTERNEL_SERVER |
There was a problem hiding this comment.
INTERNAL..................aldksgo
penrose15
approved these changes
Jul 5, 2024
| @@ -0,0 +1,12 @@ | |||
| ## 🌱 관련 이슈 | |||
| /** | ||
| * CUSTOM | ||
| */ | ||
| @ExceptionHandler(BaseException.class) |
There was a problem hiding this comment.
customexception을 가장 마지막에 둔 이유가 있을까요?
| @@ -2,6 +2,7 @@ spring: | |||
| config: | |||
| activate: | |||
| on-profile: local | |||
| import: optional:application-secret.properties | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
[예외 클래스 관련 안내 사항]
[성공 관련 안내 사항]
return ApiResponse.success(SuccessType, data);형식으로 처리하시면 되겠습니다.return ResponseEntity.created(location).build();로 처리하시면 됩니다.return ResponseEntity.noContent().build();로 처리하시면 되겠습니다.📝 참고사항
[BaseException 클래스 다이어그램]
[API 공통 응답 테스트]
📚 기타