Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test schema versioning #942

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Test schema versioning #942

wants to merge 6 commits into from

Conversation

TaiWilkin
Copy link
Contributor

New schema

Updates the build script to store new versions under a version folder as they're created.

Pull Requests to update the schema in related repositories

N/A

@mjknight50 mjknight50 marked this pull request as ready for review November 4, 2024 16:37
@mjknight50 mjknight50 requested review from a team as code owners November 4, 2024 16:37
mjknight50
mjknight50 approved these changes Nov 4, 2024
View reviewed changes
Copy link

@mjknight50 mjknight50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG. Also received approval from Sanja and Steve.
I will follow up with some additional documentation.

@mjknight50
Copy link

Related ADR:
https://github.com/department-of-veterans-affairs/vets-api/blob/master/modules/pensions/documentation/adr/0009-vets-json-schema-versioning.md

@rmtolmach rmtolmach marked this pull request as draft November 5, 2024 14:52
@rmtolmach
Copy link
Contributor

Converting to a draft until documentation is done. Slack thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjknight50 mjknight50 mjknight50 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TaiWilkin @mjknight50 @rmtolmach