Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[53281] Update loan history schema. #748

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

data-doge
Copy link
Contributor

@data-doge data-doge commented Feb 13, 2023

Updating loan history schema to reflect changes made in department-of-veterans-affairs/vets-website#23249 and department-of-veterans-affairs/vets-website#23254.

New schema

department-of-veterans-affairs/va.gov-team#53281

Pull Requests to update the schema in related repositories

department-of-veterans-affairs/vets-website#23372 (need to update vets-json-schema version after merged)
department-of-veterans-affairs/vets-api#0000 (need to update vets-json-schema version after merged)

data-doge added a commit to department-of-veterans-affairs/vets-website that referenced this pull request Feb 13, 2023
See department-of-veterans-affairs/vets-json-schema#748. After updating vets-json-schema to include the changes to the loan history form, we can remove a little bit of hard-coded code.
@data-doge data-doge marked this pull request as ready for review February 13, 2023 20:54
@data-doge data-doge requested review from a team as code owners February 13, 2023 20:54
@rjohnson2011
Copy link

Looks like you'll need to update the version. Can you do so then ping me to approve please?

@RachalCassity
Copy link
Member

@data-doge Can this PR be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants