Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.68.0 to 1.69.0 #19637

Merged
merged 6 commits into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ GEM
parallel (1.26.3)
parallel_tests (4.7.2)
parallel
parser (3.3.5.1)
parser (3.3.6.0)
ast (~> 2.4.1)
racc
patience_diff (1.2.0)
Expand Down Expand Up @@ -937,17 +937,17 @@ GEM
actionpack (>= 5.2, < 8.1)
railties (>= 5.2, < 8.1)
rtesseract (3.1.3)
rubocop (1.68.0)
rubocop (1.69.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
rubocop-ast (>= 1.36.1, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.33.0)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.36.1)
parser (>= 3.3.1.0)
rubocop-capybara (2.21.0)
rubocop (~> 1.41)
Expand Down
1 change: 0 additions & 1 deletion app/models/bgs_dependents/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def serialize_dependent_result(
family_relationship_type,
optional_fields = {}
)

{
vnp_participant_id: participant[:vnp_ptcpnt_id],
participant_relationship_type_name: participant_relationship_type,
Expand Down
1 change: 0 additions & 1 deletion lib/mpi/messages/add_person_implicit_search_message.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ def initialize(first_name:,
address: nil,
idme_uuid: nil,
logingov_uuid: nil)

@first_name = first_name
@last_name = last_name
@ssn = ssn
Expand Down
1 change: 0 additions & 1 deletion lib/mpi/messages/add_person_proxy_add_message.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ def initialize(first_name:,
edipi:,
icn:,
search_token:)

@first_name = first_name
@last_name = last_name
@ssn = ssn
Expand Down
1 change: 0 additions & 1 deletion lib/mpi/messages/update_profile_message.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def initialize(first_name:,
idme_uuid: nil,
logingov_uuid: nil,
edipi: nil)

@first_name = first_name
@last_name = last_name
@ssn = ssn
Expand Down
1 change: 0 additions & 1 deletion lib/sign_in/logingov/service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def initialize(optional_scopes: [])
def render_auth(state: SecureRandom.hex,
acr: Constants::Auth::LOGIN_GOV_IAL1,
operation: Constants::Auth::AUTHORIZE)

Rails.logger.info('[SignIn][Logingov][Service] Rendering auth, ' \
"state: #{state}, acr: #{acr}, operation: #{operation}, " \
"optional_scopes: #{optional_scopes}")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1285,7 +1285,6 @@ def errors_array

def collect_error_messages(detail: 'Missing or invalid attribute', source: '/',
title: 'Unprocessable Entity', status: '422')

errors_array.push({ detail:, source:, title:, status: })
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ def errors_array

def collect_error_messages(detail: 'Missing or invalid attribute', source: '/',
title: 'Unprocessable Entity', status: '422')

errors_array.push({ detail:, source:, title:, status: })
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ def errors_array

def collect_error_messages(detail: 'Missing or invalid attribute', source: '/',
title: 'Unprocessable Entity', status: '422')

errors_array.push({ detail:, source:, title:, status: })
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ class DocumentServiceBase < ServiceBase
# rubocop:disable Metrics/ParameterLists
def generate_upload_body(claim_id:, system_name:, doc_type:, pdf_path:, file_name:, birls_file_number:,
participant_id:, tracked_item_ids:)

payload = {}

data = build_body(claim_id:, system_name:, doc_type:, file_name:, participant_id:,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def representative_contact_details(data)
}
end

# rubocop:disable Metrics/LineLength
# rubocop:disable Layout/LineLength
# Disabled due to two extremely long keys.
def appointment_options(data)
{
Expand All @@ -208,7 +208,7 @@ def appointment_options(data)
"#{PAGE2_KEY}.Provide_The_Names_Of_The_Individuals_Here[0]": data.consent_team_members&.to_sentence
}
end
# rubocop:enable Metrics/LineLength
# rubocop:enable Layout/LineLength

def header_options(data)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@
end

it 'sets the cert_through date based on current date relative to award end dates' do
# rubocop:disable RSpec/ConstantDefinitionInBlock
# rubocop:disable Lint/ConstantDefinitionInBlock
VerificationTest = Struct.new(:act_end)
# rubocop:enable RSpec/ConstantDefinitionInBlock
# rubocop:enable Lint/ConstantDefinitionInBlock
award_dates = [
Time.zone.parse('2024-08-10'),
Time.zone.parse('2024-10-15'),
Expand Down
Loading