Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form dig, and add metrics for flashes. #19630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dfitchett
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • Fixes a form 526 dig to get flashes and adds metrics for flashes added to claims
  • On submission of 526 form, we attempt to check flashes to see if it includes a particular flash on the claim.
  • I'm on the Employee Experience team; we work with the Disability Experience team which maintains Form 526.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Old behavior:
    • Incorrect dig to get flashes resulting in always having empty array of flashes and never logging statement
  • New behavior:
    • correct form dig
    • logs list of flashes along with submitted claim id if a flash prototype is in the list of flashes. Only current prototype is Amyotrophic Lateral Sclerosis flash and is behind the feature flag disability_526_ee_process_als_flash and is not enabled in production
    • pushes an increment to datadog for each flash, prototype or not
    • this will allow gathering metrics for flashes applied via va.gov form 526 submission

What areas of the site does it impact?

  • no user functionality is affected
  • metrics in datadog will be available on this dashboard

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants