-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 34966 #23562
Draft
cacevesva
wants to merge
667
commits into
main
Choose a base branch
from
feature/APPEALS-34966
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/appeals 34966 #23562
+226,200
−1,124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Save Button Is Not Enabled When VA DOR Date Is Updated (#22049) * fix for the save changes button * fixing jest and rspecs * fix rspec * updated parameters in controller to permit batch id (#22084) * Update explain controller appeal_affinity to test if appeal is a correspondence (#22092) * added guard clause to response (#22113) * APPEALS-51209: UAT Test Data Workflow Does Not Create Documents When Creating Correspondences (#22115) * added guard clause to response * added document creation to UAT test correspondence workflow * remove domplexity note creation * Sivakesh/appeals 48375 (#22064) * #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <[email protected]> * Refactor Review Package Frontend (#22073) * Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * APPEALS-51367: Fixed Bug with Improper Routes in Review Package (#22126) * Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <[email protected]> * APPEALS-50730 : Auto Assign Algorithm Continues when No Available Users are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * removed unused task (#22143) * Ki/APPEALS-42516 - Create Details Page Shell (#22122) * Reforged * Reinstante VetCorrespondence * correspondence_details temporary fix * Sivakesh/appeals 48375 (#22064) * #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <[email protected]> * Refactor Review Package Frontend (#22073) * Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * Refactor Review Package Frontend (#22073) * Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * APPEALS-51367: Fixed Bug with Improper Routes in Review Package (#22126) * Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <[email protected]> * APPEALS-50730 : Auto Assign Algorithm Continues when No Available Users are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * APPEALS-42516 - Controller Updates, Spec and Route details * Remove facols file --------- Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: Rnmarshall93 <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> * Lint fixes (#22134) * Lint fixes * Updated the color variables * Updated the color variables for hsl values * Fix for MergeableSelector for corr class * Fix rubocop offenses * Continue fixing rubocop offenses * Update gemfile lint rubocop offense * MergeableSelector fix for class cf-form-textinput * Fix for the newly added lint issues * Fix for the cf-form-textinput lint issue * Fix for MergeableSelector in team_management.scss --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> * Revert "Ki/APPEALS-42516 - Create Details Page Shell (#22122)" This reverts commit 667d590. * Fix flaky lint & specs --------- Co-authored-by: vinner57 <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Rnmarshall93 <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: KiMauVA <[email protected]> Co-authored-by: IsaiahBar <[email protected]>
* fix code climate issues * fix 4 parameters isseus * fix argument error code climate * fix lint issues * lint fix * fix lint issuues * adding double quotes
* removed all glamor css. * fixed linting.
* APPEALS-42516 - CSS Updates * APPEALS-42516 - Additional CSS for View all link * Deleting empty rulesets for linter * Lintagain * &nsp removal --------- Co-authored-by: cacevesva <[email protected]>
* Completed Tabs link code modifications * Modified the code changes as commented
…ews Dropdown (#22230) * added correspondence dropdown checks on the user model * refactored Switch Views dropdown to populate values from backend * removed unused props * added missing param that was passed to method.
* filtered attorney tasks to not include correspondence * added correspondence filtering for other Appeal Queues.
…ews Dropdown (#22230) * added correspondence dropdown checks on the user model * refactored Switch Views dropdown to populate values from backend * removed unused props * added missing param that was passed to method.
* filtered attorney tasks to not include correspondence * added correspondence filtering for other Appeal Queues.
* overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors
…sks. (#22256) * overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors * adding temporary under_constructions task urls for merge and split tasks.
…22226) * APPEALS-32518 - Added recordStatus to page pathways * APPEALS-42518 - Updated Correspondence Status pathways, controller * APPEALS-42518 - Remap status to live in correspondence model * Remove unedited file linting changes * Second filechange * APPEALS-42518 - Updated RSpecs * Linting --------- Co-authored-by: cacevesva <[email protected]>
* #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks
…n for the end return
…of-veterans-affairs/caseflow into Justin/APPEALS-54933
…evious "margin-bottom" value of 5px
…of-veterans-affairs/caseflow into Justin/APPEALS-54933
…APPEALS-54933 Details: Correspondence and Appeals Tasks: Add Task Action: Other motion
* Added new return to inbound ops action for corr mail task * remove old unneeded comments
…/APPEALS-34966-merge-conflicts Merging Correspondence Details (APPEALS-34965) into APPEALS-34966
* Feature test cases for Return to Inbound Ops * Spell check fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling