-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
progress bar setup, api utils, and cancel button logic #23346
base: main
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 891e2dc and detected 15 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
…PdfDoc to ProgressBar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@@ -56,6 +56,7 @@ def documents | |||
document.to_hash.tap do |object| | |||
object[:opened_by_current_user] = read_documents_hash[document.id] || false | |||
object[:tags] = tags_by_doc_id[document.id].to_a | |||
object[:file_size] = document.file_size | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary change for development
def file_size | ||
File.size(default_path) || 0 | ||
end | ||
|
||
def file_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary change for development
…pecific across ApiUtil, pdfDocument, and jest tests
Resolves Jira Issue Title
Description
Contains multiple stories from this epic
https://jira.devops.va.gov/browse/APPEALS-47329
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling