APPEALS-24070 | Fix Flakey Test Effort | VHA #23302
Draft
+31
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_hearing_request_type/vso_change_hearing_request_type_spec.rb (#23249) * Initial commit added an extra couple of expect statements to try to fix test flakyness in the vso change hearing request type feature spec file. * Added one more waiting expect statement and removed variable reassignment from the test. * Changed the button click to safe click to try to make it less flaky.
2 tasks
|
Code Climate has analyzed commit 63f1fcd and detected 0 issues on this pull request. View more on Code Climate. |
…change_history/claim_history_service_spec.rb (#23283) * Updated the change history query to use Time.zone.now from ruby instead of the current timestamp from postgres to make the days waiting behavior more consistent in the app and in the testing environments. * Fixed a code climate brakeman warning. * Rewrote a test expectation since it wasn't always deterministic.
…ness. (#23341) Co-authored-by: Brandon Lee Dorner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://jira.devops.va.gov/browse/APPEALS-24070
Description
This is an effort to reduce the amount of flakey tests in our repo. We expect the above jira list to grow but this will at least reduce the amount of flakey tests.
Acceptance Criteria